Markers
Table of Contents
DemomodeCommand.php
| Type | Line | Description |
|---|---|---|
| TODO | 32 | a valid error process |
ImportSurveyCommand.php
| Type | Line | Description |
|---|---|---|
| TODO | 16 | Add support to customize these. |
InstallCommand.php
| Type | Line | Description |
|---|---|---|
| TODO | 71 | a valid error process |
InstallFromConfigCommand.php
| Type | Line | Description |
|---|---|---|
| TODO | 126 | a valid error process |
| TODO | 195 | Check if exists |
| TODO | 199 | Check if exists |
| TODO | 203 | Check if exists |
ResetPasswordCommand.php
| Type | Line | Description |
|---|---|---|
| TODO | 43 | a valid error process |
WipeCommand.php
| Type | Line | Description |
|---|---|---|
| TODO | 171 | a valid error process |
fonts.php
| Type | Line | Description |
|---|---|---|
| TODO | 173 | move this section to new fonts model once it become needed |
packages.php
| Type | Line | Description |
|---|---|---|
| TODO | 56 | Delete this? See #15108. |
Authentication.php
| Type | Line | Description |
|---|---|---|
| TODO | 97 | Should not be possible to get here after LS4. See LsDefaultDataSets::getDefaultPluginsData(). |
| TODO | 166 | for sake of clarity, the plugin function should be renamed to authenticate(). |
ConditionsAction.php
| Type | Line | Description |
|---|---|---|
| TODO | 691 | Better way than to extract $args |
| TODO | 799 | Code duplication |
| TODO | 2268 | Not used |
Database.php
| Type | Line | Description |
|---|---|---|
| TODO | 54 | move called functions to their respective Controllers |
| TODO | 47 | : use model (and validate if we do it in model rules) |
DataEntry.php
| Type | Line | Description |
|---|---|---|
| TODO | 1712 | $surveytable is unused. Remove it. |
Export.php
| Type | Line | Description |
|---|---|---|
| TODO | 1083 | $aSurveyInfo is not used anymore. Remove it. |
Expressions.php
| Type | Line | Description |
|---|---|---|
| TODO | 82 | Remove it - does nothing |
ExpressionValidate.php
| Type | Line | Description |
|---|---|---|
| TODO | 272 | : Find error in class name, style etc .... |
Labels.php
| Type | Line | Description |
|---|---|---|
| TODO | 378 | : check if it's currently used. |
| TODO | 476 | Move save logic into service class. |
| TODO | 673 | Not used? |
| TODO | 691 | Not used? |
| TODO | 132 | $sExtension is not used. Remove it. |
ParticipantsAction.php
| Type | Line | Description |
|---|---|---|
| TODO | 1789 | Where is this called from? |
| TODO | 2020 | Where is this called from? |
| TODO | 2105 | Where is this called from? |
| TODO | 2185 | Where is this called from? |
| TODO | 2280 | Use user session? |
| TODO | 2280 | Used? |
| TODO | 1905 | What's the Difference between lang and langdata? |
| TODO | 2516 | This is a comma separated string of ids |
| TODO | 2551 | This code can't be reached |
| TODO | 2620 | Maybe do this with SQL instead? |
PluginHelper.php
| Type | Line | Description |
|---|---|---|
| TODO | 6 | Better name? |
| TODO | 44 | Assume this for all plugins? |
PluginManagerController.php
| Type | Line | Description |
|---|---|---|
| TODO | 23 | Apply new permission 'extensions' instead of 'settings'. |
| TODO | 206 | Defensive programming |
| TODO | 659 | Might have different file fetcher. |
| TODO | 675 | Duplicate from themes.php. |
| TODO | 705 | Duplicate from themes.php. |
| TODO | 320 | Break out to separate method. |
PrintableSurvey.php
| Type | Line | Description |
|---|---|---|
| TODO | 328 | Fallthru on purpose? |
Saved.php
| Type | Line | Description |
|---|---|---|
| TODO | 70 | write function |
SurveysGroupsController.php
| Type | Line | Description |
|---|---|---|
| TODO | 261 | : find where it shown |
| TODO | 261 | : fix $_POST call |
Themes.php
| Type | Line | Description |
|---|---|---|
| TODO | 524 | Used? Previous name: _strip_ext |
| TODO | 1435 | Move to service class |
| TODO | 1435 | Same logic for survey theme |
| TODO | 291 | Don't branch on $_POST, but on config.xml <type> tag. |
| TODO | 304 | Replace with extension installer factory. |
| TODO | 320 | If you want to do nice file upload summary, you need to define a |
| TODO | 368 | Always check if successful. |
| TODO | 375 | Move all this to new SurveyThemeInstaller class (same as done for QuestionThemeInstaller). |
| TODO | 410 | Always check if successful. |
| TODO | 414 | make proper import manifest for questiontheme in configuration class |
| TODO | 424 | Always check if successful. |
| TODO | 549 | check if we can load template without needing the model, only from xml, so we can load the theme editor even when it is not installed |
| TODO | 1161 | check if this aData is still used |
| TODO | 1173 | try if it can be removed |
Tokens.php
| Type | Line | Description |
|---|---|---|
| TODO | 349 | separate this function in two: one for single delete and one for multiple delete |
| TODO | 38 | : check if it does something different than the model function |
| TODO | 385 | Why needed? |
| TODO | 631 | This part could be refactored into function like "insertToken()" |
| TODO | 1540 | Rename 'ok' to something meaningful. |
Update.php
| Type | Line | Description |
|---|---|---|
| TODO | 595 | : if no update available, set session about it... |
AdminController.php
| Type | Line | Description |
|---|---|---|
| TODO | 246 | check if it is the case for all controllers, if not normalize it, so 3rd party coder can easily extend any LS Core controller/action/view. |
AssessmentController.php
| Type | Line | Description |
|---|---|---|
| TODO | 214 | Show error details to the user? |
| TODO | 258 | Show error details to the user? |
InstallerController.php
| Type | Line | Description |
|---|---|---|
| TODO | 717 | Not used? Compare models/InstallerConfigForm::getHasMinimumRequirements |
LimereplacementfieldsController.php
| Type | Line | Description |
|---|---|---|
| TODO | 457 | document me .. |
PluginsController.php
| Type | Line | Description |
|---|---|---|
| TODO | 7 | Not used, copied to admin/pluginmanager.php. Delete this file? |
| TODO | 7 | Actually, it's used for action direct. |
QuestionAdministrationController.php
| Type | Line | Description |
|---|---|---|
| TODO | 169 | Move to service class |
| TODO | 310 | php warning (Missing return statement) |
| TODO | 450 | is this action still in use?? where in the frontend? |
| TODO | 645 | document me |
| TODO | 711 | Permission check hard when both sid and gid are given. |
| TODO | 747 | Permission |
| TODO | 747 | Should be GET, not POST |
| TODO | 766 | Permission |
| TODO | 766 | Should be GET, not POST |
| TODO | 822 | Document. |
| TODO | 822 | Too many arguments. |
| TODO | 871 | docs |
| TODO | 1019 | document me. |
| TODO | 1019 | is this used in frontend somewherer? can't find it |
| TODO | 2324 | document me |
| TODO | 2344 | document me. |
| TODO | 2344 | move this function somewhere else, this should not be part of controller ... (e.g. model) |
| TODO | 2518 | Move to PreviewModalWidget? |
| TODO | 183 | No difference between true and false? |
| TODO | 207 | 'assessmentvisible' => false, |
| TODO | 217 | Problem with CSRF cookie when entering directly after login. |
| TODO | 550 | Double check |
| TODO | 826 | calcul correct value |
| TODO | 829 | Fix question type 'A'. Needed? |
| TODO | 1041 | Rename Variable for better readability. |
| TODO | 1258 | $questionMetaData should be $questionThemeSettings |
| TODO | 1525 | 1591979134468: this should be get from the question model |
| TODO | 1553 | Better solution: Hard-code allowed CSS classes. |
| TODO | 1622 | Difference between create and update permissions? |
| TODO | 1800 | 'assessmentvisible' => false, |
RegisterController.php
| Type | Line | Description |
|---|---|---|
| TODO | 339 | : move xss filtering in model |
StatisticsUserController.php
| Type | Line | Description |
|---|---|---|
| TODO | 45 | Not used? |
SurveyIndex.php
| Type | Line | Description |
|---|---|---|
| TODO | 273 | can this be moved to the top? |
SurveyAdministrationController.php
| Type | Line | Description |
|---|---|---|
| TODO | 584 | is this function used? the function editlocalsetting does not exists (also not in old controller surveyadmin) |
| TODO | 892 | this could go to the questiongroupAdministrationController ? |
| TODO | 1145 | this could go into surveymenucontroller |
| TODO | 2241 | Add TypeDoc. |
| TODO | 2280 | this should be separated in two actions import and copy ... |
| TODO | 2522 | this function should be moved to another controller (?) |
| TODO | 2600 | While refactoring (at some point) this function should be removed and only one unique identifier should be used |
| TODO | 2624 | is this new implementation??? |
| TODO | 2661 | Change function name to _showOrganizeGroupsAndQuestions? |
| TODO | 2661 | Does actually not show anything, but gets data. So getReorderFormData()? |
| TODO | 175 | getGlobalSetting() DEPRECATED |
| TODO | 178 | getGlobalSetting() DEPRECATED |
SurveysController.php
| Type | Line | Description |
|---|---|---|
| TODO | 86 | Remove? It seems this can never happen because it's already caught by LSYii_Application::onException() (see commit c792c2e). |
| TODO | 134 | Remove comment code. |
ThemeOptionsController.php
| Type | Line | Description |
|---|---|---|
| TODO | 826 | While refactoring (at some point) this function should be removed and only one unique identifier should be used |
UploaderController.php
| Type | Line | Description |
|---|---|---|
| TODO | 120 | Split into two controller methods. |
| TODO | 255 | : unlink this file since this is just a preview. But we can do it only if it's not needed, and still needed to have the file content |
UserGroupController.php
| Type | Line | Description |
|---|---|---|
| TODO | 154 | Is this still right on 6.0? |
| TODO | 490 | Show error message? |
LimeMailer.php
| Type | Line | Description |
|---|---|---|
| TODO | 612 | Original AltBody is overwritten by msgHTML. Do we need to set it again if there was one? |
LS_Twig_Extension.php
| Type | Line | Description |
|---|---|---|
| TODO | 622 | in_array_r is not defined - delete this method? |
LsDefaultDataSets.php
| Type | Line | Description |
|---|---|---|
| TODO | 1528 | This tutorial is broken when subquestions and answer options are on the same page. |
LSETwigViewRenderer.php
| Type | Line | Description |
|---|---|---|
| TODO | 233 | missing return statement (php warning) |
| TODO | 399 | missing return statement (php warning) |
| TODO | 663 | move all the display logic to surveyRuntime so we don't need this function here |
| TODO | 792 | find a way to fix in beforeCloseHtml @see https://bugs.limesurvey.org/view.php?id=13889 |
| TODO | 101 | Panic or default to something else? |
| TODO | 206 | Panic or default to something else? |
| TODO | 707 | Same issue as commit 2972aea41c51c74db95bfe40c337ae839471152c |
LSUserIdentity.php
| Type | Line | Description |
|---|---|---|
| TODO | 70 | rename the plugin function authenticate() |
LSYii_Application.php
| Type | Line | Description |
|---|---|---|
| TODO | 148 | check the whole configuration process. It must be easier and clearer. Too many repitions |
| TODO | 486 | get the tags, filters, etc |
LSYii_ClientScript.php
| Type | Line | Description |
|---|---|---|
| TODO | 298 | check if tmp directory can be named differently via config |
LSYii_ImageValidator.php
| Type | Line | Description |
|---|---|---|
| TODO | 54 | Why hard-coded? |
LSYii_Validators.php
| Type | Line | Description |
|---|---|---|
| TODO | 249 | Check for other schemes? FTP? vbscript? |
| TODO | 260 | Recurse? |
Authdb.php
| Type | Line | Description |
|---|---|---|
| TODO | 182 | Should we show the actual error? Taking a conservative approach of not revealing the actual cause for now. |
AzureOAuthSMTP.php
| Type | Line | Description |
|---|---|---|
| TODO | 44 | Remove this once we drop support for PHP 7.2 |
TFAUserKey.php
| Type | Line | Description |
|---|---|---|
| TODO | 95 | should be static |
LoadQuestionTypes.php
| Type | Line | Description |
|---|---|---|
| TODO | 8 | Configure autoloader in composer.json instead of this |
RenderMultipleChoice.php
| Type | Line | Description |
|---|---|---|
| TODO | 139 | : check if $sValueHidden === $sValue |
RenderMultipleChoiceWithComments.php
| Type | Line | Description |
|---|---|---|
| TODO | 134 | : check if it should be the same than javavalue |
| TODO | 194 | : check if it should be the same than javavalue |
SurveyCommonAction.php
| Type | Line | Description |
|---|---|---|
| TODO | 910 | Make quick-menu user configurable |
| TODO | 265 | : while refactoring, we must replace the use of $aViewUrls by $aData[.. conditions ..], |
| TODO | 294 | : http://goo.gl/ABl5t5 |
| TODO | 412 | Real fix: No database queries while doing database update, meaning |
| TODO | 652 | Don't call getAdvancedSettingsWithValues without a question object. |
| TODO | 850 | : create subfunctions |
WrongTemplateVersionException.php
| Type | Line | Description |
|---|---|---|
| TODO | 9 | Put in another folder? |
FormElement.php
| Type | Line | Description |
|---|---|---|
| TODO | 9 | Is this class needed, or can it be included in widget DVOs? |
| TODO | 9 | $name is always null, always === $id. |
MassiveActionsWidget.php
| Type | Line | Description |
|---|---|---|
| TODO | 57 | common view for all modal types. |
PreviewModalWidget.php
| Type | Line | Description |
|---|---|---|
| TODO | 7 | Split into two widgets? |
AdvancedSettingWidget.php
| Type | Line | Description |
|---|---|---|
| TODO | 23 | Classes instead of array. |
GeneralOptionWidget.php
| Type | Line | Description |
|---|---|---|
| TODO | 18 | Classes instead of switch. |
GroupSelectorGeneralOption.php
| Type | Line | Description |
|---|---|---|
| TODO | 45 | array_map? |
SettingsWidget.php
| Type | Line | Description |
|---|---|---|
| TODO | 326 | $name is not used |
| TODO | 408 | $form is not used. |
| TODO | 466 | $name is not used |
| TODO | 466 | $form is not used |
| TODO | 569 | $name is not used |
| TODO | 517 | Where is this class added in the first place?? |
| TODO | 580 | $itemMetaData['htmlOtions']['id']=$itemName.$key or something like this |
UserPermissionsWidget.php
| Type | Line | Description |
|---|---|---|
| TODO | 11 | Classes instead of switch. |
ajax_helper.php
| Type | Line | Description |
|---|---|---|
| TODO | 161 | Check if user is logged in |
import_helper.php
| Type | Line | Description |
|---|---|---|
| TODO | 1292 | Use transactions to prevent orphaned data and clean rollback on errors |
| TODO | 121 | Should this depend on $bTranslateLinksFields? |
| TODO | 362 | Should this depend on $bTranslateLinksFields? |
| TODO | 664 | Should this depend on $options['translinkfields']? |
| TODO | 856 | Should this depend on $options['translinkfields']? |
| TODO | 1632 | Should this depend on $bTranslateLinksFields? |
| TODO | 3009 | set proper default |
label_helper.php
| Type | Line | Description |
|---|---|---|
| FIXME | 74 | undefined function |
| TODO | 179 | Show an actual error message |
statistics_helper.php
| Type | Line | Description |
|---|---|---|
| TODO | 1683 | Support three or more duplicates. |
| FIXME | 2037 | $MyCache is undefined |
| TODO | 2548 | Support three or more duplicates. |
common_helper.php
| Type | Line | Description |
|---|---|---|
| TODO | 834 | Move to defaulttexts helper |
| TODO | 2794 | This should probably never be used, since it returns 0 from CLI and makes PHPUnit think all is fine :( |
| TODO | 3006 | Make the days configurable |
| FIXME | 596 | rename and/or document this |
| TODO | 1690 | SQrelevance for different scales? $fieldmap[$fieldname]['SQrelevance']=$abrow['relevance']; |
| TODO | 2342 | input Survey Object |
| TODO | 2362 | input Survey Object |
| TODO | 2980 | : Adding the onload/onhover etc ... or remove this false security function |
| TODO | 4356 | remove one of the Yii::app()->session see bug #5901 |
| TODO | 4589 | RFC7239 full implementation (https://datatracker.ietf.org/doc/html/rfc7239#section-5.2) |
export_helper.php
| Type | Line | Description |
|---|---|---|
| TODO | 2605 | refactor and simplify this code |
em_core_helper.php
| Type | Line | Description |
|---|---|---|
| TODO | 2630 | Unify errors and warnings with a EMErrorComparableInterface |
| TODO | 100 | - change this back to false |
| TODO | 565 | try to determine datatype? |
| TODO | 1972 | - Since want to use <span> for dynamic substitution, what if there are recursive substititons? |
em_manager_helper.php
| Type | Line | Description |
|---|---|---|
| TODO | 3274 | Keep method as-is but factor out content to new class; add unit tests for class |
| TODO | 6876 | : add directly hidden input in page without return it. |
| TODO | 9688 | : validate if it work : unsure it was shown always to user (nojs ?) |
| TODO | 29 | Fix autoloading of warnings. |
| TODO | 267 | - add example from survey using assessments |
| TODO | 356 | ?? |
| TODO | 406 | - ?? |
| TODO | 410 | ?? |
| TODO | 1262 | - implement qcode naming for this |
| TODO | 1458 | generic validation as to dateformat[SGQA].value : BUT not same in PHP and JS |
| TODO | 2640 | - create equations for these? |
| TODO | 2643 | ? How does it work? |
| TODO | 3047 | - create em_num_files class so can sepately style num_files vs. num_answers |
| TODO | 3285 | - do I need to force refresh, or trust that createFieldMap will cache langauges properly? |
| TODO | 3608 | Internal error if this happens |
| TODO | 4093 | - in a running survey, only need to process the current Group. For Admin mode, do we need to process all prior questions or not? |
| TODO | 4228 | - cache results and generated JavaScript equations? |
| TODO | 4575 | default should eventually be false |
| TODO | 4751 | only important thing from StartProcessingGroup? |
| TODO | 4965 | only important thing from StartProcessingGroup? |
| TODO | 5015 | - now that using $this->updatedValues, may be able to remove local copies of it (unless needed by other sub-systems) |
| TODO | 5102 | Internal error if this happens |
| TODO | 5483 | only important thing from StartProcessingGroup? |
| TODO | 5627 | - what is desired behavior? |
| TODO | 5765 | how used if random? |
| TODO | 5820 | is this needed? |
| TODO | 5930 | is this needed? |
| TODO | 5966 | is this needed? |
| TODO | 6010 | is this needed? |
| TODO | 6045 | is this needed? |
| TODO | 6075 | - check this |
| TODO | 6080 | - why is array_unique needed here? |
| TODO | 6168 | - what about 'other'? |
| TODO | 6212 | - what about 'other'? |
| TODO | 6237 | - what about 'other'? |
| TODO | 6426 | check for errors? |
| TODO | 6431 | - currently invalidates all - should only invalidate those that truly fail validation rules. |
| TODO | 6786 | - what if this is called using Survey or Data Entry format? |
| TODO | 7291 | Internal error if this happens |
| TODO | 7650 | - is different type needed for text? Or process value to striphtml? |
| TODO | 8458 | Make a wrapper class around date converter, which constructor takes to-lang and from-lang |
| TODO | 8714 | jsName_on will never be returned? |
em_cache_helper.php
| Type | Line | Description |
|---|---|---|
| TODO | 118 | Setting per survey. |
| TODO | 118 | Don't cache questions with expressions. |
| TODO | 154 | check ajaxmode |
EMWarningHTMLBaker.php
| Type | Line | Description |
|---|---|---|
| TODO | 55 | Factor out in warning classes OOP |
frontend_helper.php
| Type | Line | Description |
|---|---|---|
| TODO | 1440 | Rename |
| TODO | 1440 | Move HTML to view |
| TODO | 2114 | Deprecated - Question timers no longer use cookies |
| TODO | 18 | Why needed? |
| TODO | 1039 | rewrite this THE YII WAY !!!! (application/vendor + internal config for namespace + aliases; etc) |
| TODO | 2235 | something unfinished here? |
Hash.php
| Type | Line | Description |
|---|---|---|
| FIXME | 106 | !!! |
LayoutHelper.php
| Type | Line | Description |
|---|---|---|
| TODO | 402 | Make quick-menu user configurable |
| TODO | 344 | : create subfunctions |
qanda_helper.php
| Type | Line | Description |
|---|---|---|
| TODO | 113 | This can be cached in some special cases. |
| TODO | 909 | : move to a dedicated function |
| TODO | 1489 | : check if $sValueHidden === $sValue |
| TODO | 1648 | : check if it should be the same than javavalue |
| TODO | 1681 | $value is not defined for some execution paths. |
| TODO | 1693 | : check if it should be the same than javavalue |
| TODO | 1778 | Regression here? Should use LEMval(minfiles) like above |
| TODO | 4396 | What is this? What is happening here? |
questionHelper.php
| Type | Line | Description |
|---|---|---|
| TODO | 1199 | add these later? "1F", |
| TODO | 1209 | add these later? "1F", |
remotecontrol_handle.php
| Type | Line | Description |
|---|---|---|
| TODO | 3223 | Need to clean up return array, especially the case when response was added but file not uploaded. |
| TODO | 3223 | See discussion: https://bugs.limesurvey.org/view.php?id=13794 |
sanitize_helper.php
| Type | Line | Description |
|---|---|---|
| TODO | 311 | define the exact format of the username |
| TODO | 324 | define the exact format of the username |
SurveyRuntimeHelper.php
| Type | Line | Description |
|---|---|---|
| TODO | 1391 | : find/get current qid for processing string |
| TODO | 1469 | : move to coreReplacements ? Can be good. |
| TODO | 166 | To respect object oriented design, all those "states" should be move to Response model, or its related models via relations. |
| TODO | 214 | move somewhere else |
| TODO | 280 | - retrieveAnswers is slow - queries database separately for each question. May be fixed in _CI or _YII ports, so ignore for now |
| TODO | 744 | set this to true if in admin mode but not if running a survey |
| TODO | 863 | twig |
| TODO | 1219 | check that line: |
| TODO | 1572 | find where they are defined before this call |
| TODO | 1641 | check with markus why $loadall, it's never ever defined, even in master branch |
| TODO | 1743 | check this: |
surveytranslator_helper.php
| Type | Line | Description |
|---|---|---|
| TODO | 1270 | Should not give back different data types |
updatedb_helper.php
| Type | Line | Description |
|---|---|---|
| TODO | 3280 | Move to class? |
| TODO | 999 | Inject user model instead. Polling for user will create a session, which breaks on command-line. |
| TODO | 1535 | Don't use models in updatedb_helper. |
userstatistics_helper.php
| Type | Line | Description |
|---|---|---|
| TODO | 1811 | Support three or more duplicates. |
viewHelper.php
| Type | Line | Description |
|---|---|---|
| TODO | 255 | : filter inline javascript (onclick etc ..., but don't filter EM javascript) Maybe doing it directly in LEM->GetLastPrettyPrintExpression(); |
BigData.php
| Type | Line | Description |
|---|---|---|
| TODO | 233 | No other types supported, ever? |
ExtensionUpdater.php
| Type | Line | Description |
|---|---|---|
| TODO | 192 | Move to parent class? |
| TODO | 31 | Create interface ExtensionModelInterface that all extension model classes implement |
FileFetcherUploadZip.php
| Type | Line | Description |
|---|---|---|
| TODO | 189 | Duplicate from themes.php. |
| TODO | 266 | Inject FileIO wrapper and add unit-test |
| TODO | 292 | When should this return false? |
PluginInstaller.php
| Type | Line | Description |
|---|---|---|
| TODO | 89 |
QuestionThemeInstaller.php
| Type | Line | Description |
|---|---|---|
| TODO | 18 | Move to parent class? |
| TODO | 114 |
ThemeUpdater.php
| Type | Line | Description |
|---|---|---|
| TODO | 22 | Survey theme, question theme, admin theme...? |
VersionFetcherServiceLocator.php
| Type | Line | Description |
|---|---|---|
| TODO | 49 | Not implemented. |
OpHandlerActiveRecordUpdate.php
| Type | Line | Description |
|---|---|---|
| TODO | 78 | Implement validateOperation() method. |
PluginManager.php
| Type | Line | Description |
|---|---|---|
| TODO | 285 | Factor out |
| TODO | 361 | Read config.xml instead. |
| TODO | 596 | Localization. |
| TODO | 623 | Localization. |
SmtpOAuthPluginBase.php
| Type | Line | Description |
|---|---|---|
| TODO | 111 | Handle token with invalid scope (ie. missing https://mail.google.com/) |
| TODO | 130 | Should we use a different exception class? |
Save.php
| Type | Line | Description |
|---|---|---|
| TODO | 173 | $this->aSaveErrors |
| TODO | 200 | $this->aSaveErrors |
AdminTheme.php
| Type | Line | Description |
|---|---|---|
| TODO | 96 | replace everywhere the call to Yii::app()->getConfig('adminstyleurl) by $oAdminTheme->sTemplateUrl; |
Answer.php
| Type | Line | Description |
|---|---|---|
| TODO | 115 | get via Question relations |
Condition.php
| Type | Line | Description |
|---|---|---|
| TODO | 74 | should be singular, not plural |
ExtensionConfig.php
| Type | Line | Description |
|---|---|---|
| TODO | 38 | Get detailed error message. |
LabelSet.php
| Type | Line | Description |
|---|---|---|
| TODO | 297 | create a Validator to be used for all such element : no need HTML, informative input used only for admin purpose. |
LSActiveRecord.php
| Type | Line | Description |
|---|---|---|
| TODO | 200 | This should also be moved to the behavior at some point. This method overrides the parent in order to raise PluginEvents for Bulk delete operations. Filter Criteria are wrapped into a CDBCriteria instance so we have a single instance responsible for holding the filter criteria to be passed to the PluginEvent, this also enables us to pass the fully configured CDBCriteria instead of the original Parameters. See {@link find()} for detailed explanation about $condition and $params. |
| TODO | 474 | Use OOP polymorphism instead of switching on class names. |
Notification.php
| Type | Line | Description |
|---|---|---|
| TODO | 272 | : via survey relations |
| TODO | 285 | this should be in Survey model (relations?) |
| TODO | 301 | this should be in Survey model |
| TODO | 317 | Check first_read = null instead? |
| TODO | 361 | read = null? |
Participant.php
| Type | Line | Description |
|---|---|---|
| TODO | 1564 | Always string?? |
| TODO | 1745 | Weird... |
| TODO | 1787 | What is id here? Could it overwrite something? |
| TODO | 1798 | Why use two variables for this? |
ParticipantAttributeName.php
| Type | Line | Description |
|---|---|---|
| TODO | 766 | Doc |
ParticipantShare.php
| Type | Line | Description |
|---|---|---|
| TODO | 29 | should be singular |
Permission.php
| Type | Line | Description |
|---|---|---|
| TODO | 779 | move to private function |
| TODO | 830 | Use data value object instead of array. |
| TODO | 525 | in entry script, if CConsoleApplication, set user as superadmin |
| TODO | 532 | plugin should not be able to override the permission system (security issue), |
| TODO | 550 | see above about entry script and superadmin |
| TODO | 556 | should not be necessary |
| TODO | 614 | that should be the only way to get the permission, |
Permissiontemplates.php
| Type | Line | Description |
|---|---|---|
| TODO | 238 | should be static |
Plugin.php
| Type | Line | Description |
|---|---|---|
| TODO | 76 | Works on all SQL systems? |
Question.php
| Type | Line | Description |
|---|---|---|
| TODO | 493 | Duplication from delete() |
| TODO | 1241 | : move other fix here ? |
| TODO | 633 | move to QuestionType |
| TODO | 1671 | Assuming no collision. |
QuestionAttribute.php
| Type | Line | Description |
|---|---|---|
| TODO | 34 | Should probably change question_attributes table to question_attribute_values |
| TODO | 66 | Remove? |
| TODO | 104 | A function should not both set and get something; split into two functions |
| TODO | 136 | A function should not both set and get something; split into two functions |
| TODO | 172 | Missign noun in function name - set multiple what? |
| TODO | 375 | Move to static property? |
| TODO | 536 | What's the opposite of a "general" attribute? How many types of attributes are there? |
| TODO | 185 | use an array like for a form submit, so we can parse it from the controller instead of using $_POST directly here |
| TODO | 190 | if (in_array($oQuestion->attributes, $sAttribute)) |
QuestionBaseRenderer.php
| Type | Line | Description |
|---|---|---|
| TODO | 240 | When to use? Where defined? |
QuestionCreate.php
| Type | Line | Description |
|---|---|---|
| TODO | 11 | This is a factory method, not a singleton. Rename to make() or create(). |
| TODO | 79 | check why return both empty array and null? |
QuestionL10n.php
| Type | Line | Description |
|---|---|---|
| FIXME | 55 | this conflicts with the attribute "question" |
QuestionTemplate.php
| Type | Line | Description |
|---|---|---|
| TODO | 387 | Move to QuestionTheme? |
| TODO | 387 | This is not the same as QuestionTheme::findQuestionMetaDataForAllTypes() which is the database layer |
| TODO | 387 | this should check the filestructure instead of the database as this is the filestructure layer |
QuestionTheme.php
| Type | Line | Description |
|---|---|---|
| TODO | 258 | Please never redirect at this level, only from controllers. |
| TODO | 340 | Move to service class |
| TODO | 373 | Replace assoc array with DTO |
| TODO | 505 | move actions to its controller and split between controller and model, related search for: 1573123789741 |
| TODO | 505 | Move to QuestionThemeInstaller |
| TODO | 728 | Naming is wrong, it does not "get", it "convertTo" |
| TODO | 728 | Possibly make a DTO for question metadata instead, and implement the ArrayAccess interface or "toArray()" |
| TODO | 317 | replace by manifest |
| TODO | 519 | Now that core question themes can't be deleted, the following check |
| TODO | 669 | should be moved into DB column (question_theme_settings table) |
| TODO | 811 | Make it always relative depending on question theme type (core, custom, user). |
| TODO | 815 | Check json_last_error. |
QuestionType.php
| Type | Line | Description |
|---|---|---|
| TODO | 77 | make it boolean instead */ |
Response.php
| Type | Line | Description |
|---|---|---|
| TODO | 219 | Internal error - wrong filename saved? |
SavedControl.php
| Type | Line | Description |
|---|---|---|
| TODO | 126 | this is a unfinished functionality resendAccesscode |
CreateSurvey.php
| Type | Line | Description |
|---|---|---|
| TODO | 78 | Localization? |
ParticipantBlacklistHandler.php
| Type | Line | Description |
|---|---|---|
| TODO | 62 | Remove 'OptOut' status from all surveys if 'blacklistallsurveys' setting is true? |
| TODO | 79 | Should we also try to match by email? |
PasswordManagement.php
| Type | Line | Description |
|---|---|---|
| TODO | 198 | it's fine to use static functions, until it is used only in controllers ... |
PermissionManager.php
| Type | Line | Description |
|---|---|---|
| TODO | 117 | : Save Permission by POST value according to current user permssion |
| TODO | 270 | Static methods cannot be mocked. |
AttributesService.php
| Type | Line | Description |
|---|---|---|
| TODO | 60 | document me Based on QuestionAdministrationController::unparseAndSetAdvancedOptions() |
| TODO | 99 | document me |
L10nService.php
| Type | Line | Description |
|---|---|---|
| TODO | 44 | document me |
QuestionAttributeHelper.php
| Type | Line | Description |
|---|---|---|
| TODO | 55 | Pure function - move outside class? |
| TODO | 101 | Pure function - move outside class? |
| TODO | 139 | Pure function - move outside class? |
| TODO | 230 | No state used, so no OOP needed, move to function at some point. |
QuickTranslation.php
| Type | Line | Description |
|---|---|---|
| TODO | 20 | All the swithc-statements could be remade using OOP instead. |
Quotas.php
| Type | Line | Description |
|---|---|---|
| TODO | 9 | Possible remove this warning |
| TODO | 94 | Refactor and remove phpmd warning |
GeneralSettings.php
| Type | Line | Description |
|---|---|---|
| TODO | 572 | Should really be saved as three fields in the database! |
| TODO | 572 | Copied from Survey:::saveTranscribeCaptchaOptions() replace uses of original copy |
SurveysGroupCreator.php
| Type | Line | Description |
|---|---|---|
| TODO | 57 | What happen if SurveysGroups saved but no SurveysGroupsettings? Transaction? |
UserManager.php
| Type | Line | Description |
|---|---|---|
| TODO | 116 | User permissions should be deleted also... |
Survey.php
| Type | Line | Description |
|---|---|---|
| TODO | 916 | this function can go directly into Surveymenu, why implemted it here? ($this is used here ...) This will be made bigger in future releases, but right now it only collects the default menu-entries |
| TODO | 1692 | : move to PermissionInterface |
| TODO | 1692 | : create an event |
| TODO | 1770 | Should really be saved as three fields in the database! |
| TODO | 2183 | use it in surveyspermission |
SurveyActivator.php
| Type | Line | Description |
|---|---|---|
| TODO | 7 | Move to models/services/survey/ folder. |
| FIXME | 394 | @ not good |
| FIXME | 398 | @ not good |
SurveyDynamic.php
| Type | Line | Description |
|---|---|---|
| TODO | 701 | This provide a first step to enable the old jQgrid selector system, and could be use for users and tokens |
SurveyLanguageSetting.php
| Type | Line | Description |
|---|---|---|
| TODO | 272 | : rename and fix this |
SurveyLink.php
| Type | Line | Description |
|---|---|---|
| TODO | 154 | this should be in survey model |
SurveyTimingDynamic.php
| Type | Line | Description |
|---|---|---|
| TODO | 168 | $language is not used locally |
Template.php
| Type | Line | Description |
|---|---|---|
| TODO | 567 | this probably not use any more. Check and remove it. |
TemplateConfig.php
| Type | Line | Description |
|---|---|---|
| TODO | 278 | document me |
| TODO | 849 | document me |
TemplateConfiguration.php
| Type | Line | Description |
|---|---|---|
| TODO | 106 | document me |
| TODO | 115 | document me |
| TODO | 139 | document me |
| TODO | 157 | document me |
| TODO | 584 | document me |
| TODO | 663 | document me |
| TODO | 911 | document me |
| TODO | 956 | document me |
| TODO | 1003 | document me |
| TODO | 1232 | document me |
| TODO | 1386 | document me |
| TODO | 1487 | document me |
| TODO | 1606 | document me |
| TODO | 231 | Move to SurveyGroup creation, right now the 'lazy loading' approach is ok. |
| TODO | 1009 | It's not clear which class prepareTemplateRendering() returns or should return. |
TemplateManifest.php
| Type | Line | Description |
|---|---|---|
| TODO | 646 | load to DB |
| TODO | 657 | Installs Theme (maybe rename importManifest to install ?) |
| TODO | 1069 | create a method "setToDefault" |
Token.php
| Type | Line | Description |
|---|---|---|
| TODO | 53 | Describe me! |
| TODO | 324 | Use HTML Purifier? |
TokenDynamic.php
| Type | Line | Description |
|---|---|---|
| TODO | 35 | Describe me! |
UpdateForm.php
| Type | Line | Description |
|---|---|---|
| TODO | 242 | $downloadid not used locally |
| TODO | 279 | : RESTORE REPLACE NEWER !! |
| TODO | 319 | Deal with error here |
| TODO | 497 | : add postgresql |
| TODO | 933 | : Could test if curl is loaded, and if not, use httprequest2 |
User.php
| Type | Line | Description |
|---|---|---|
| TODO | 246 | Not used? |
| TODO | 354 | document me |
| TODO | 441 | document me |
| TODO | 501 | document me |
| TODO | 515 | should be static |
| TODO | 821 | When there will be a more robust Group permissions system, |
| TODO | 860 | should be static |
UserGroup.php
| Type | Line | Description |
|---|---|---|
| TODO | 137 | should use save() and afterSave() methods!! |
| TODO | 338 | where is this used?? |
| TODO | 95 | seems to be unused, probably shouldn't be done like that |
UserInGroup.php
| Type | Line | Description |
|---|---|---|
| TODO | 61 | should be singular |
create-database.php
| Type | Line | Description |
|---|---|---|
| TODO | 888 | varchar(200) is too big for MySQL index, the index will be truncated to 191 chars. |