Markers
Table of Contents
DemomodeCommand.php
| Type | Line | Description |
|---|---|---|
| TODO | 32 | a valid error process |
ImportSurveyCommand.php
| Type | Line | Description |
|---|---|---|
| TODO | 17 | Add support to customize these. |
InstallCommand.php
| Type | Line | Description |
|---|---|---|
| TODO | 70 | a valid error process |
InstallFromConfigCommand.php
| Type | Line | Description |
|---|---|---|
| TODO | 125 | a valid error process |
| TODO | 194 | Check if exists |
| TODO | 198 | Check if exists |
| TODO | 202 | Check if exists |
ResetPasswordCommand.php
| Type | Line | Description |
|---|---|---|
| TODO | 43 | a valid error process |
WipeCommand.php
| Type | Line | Description |
|---|---|---|
| TODO | 176 | a valid error process |
fonts.php
| Type | Line | Description |
|---|---|---|
| TODO | 175 | move this section to new fonts model once it become needed |
packages.php
| Type | Line | Description |
|---|---|---|
| TODO | 58 | Delete this? See #15108. |
Authentication.php
| Type | Line | Description |
|---|---|---|
| TODO | 97 | Should not be possible to get here after LS4. See LsDefaultDataSets::getDefaultPluginsData(). |
| TODO | 166 | for sake of clarity, the plugin function should be renamed to authenticate(). |
ConditionsAction.php
| Type | Line | Description |
|---|---|---|
| TODO | 286 | Better way than to extract $args |
| TODO | 314 | Code duplication |
Database.php
| Type | Line | Description |
|---|---|---|
| TODO | 54 | move called functions to their respective Controllers |
| TODO | 47 | : use model (and validate if we do it in model rules) |
DataEntry.php
| Type | Line | Description |
|---|---|---|
| TODO | 1751 | $surveytable is unused. Remove it. |
Export.php
| Type | Line | Description |
|---|---|---|
| TODO | 1097 | $aSurveyInfo is not used anymore. Remove it. |
Expressions.php
| Type | Line | Description |
|---|---|---|
| TODO | 82 | Remove it - does nothing |
ExpressionValidate.php
| Type | Line | Description |
|---|---|---|
| TODO | 265 | : Find error in class name, style etc .... |
Labels.php
| Type | Line | Description |
|---|---|---|
| TODO | 376 | : check if it's currently used. |
| TODO | 474 | Move save logic into service class. |
| TODO | 624 | Not used? |
| TODO | 642 | Not used? |
| TODO | 132 | $sExtension is not used. Remove it. |
ParticipantsAction.php
| Type | Line | Description |
|---|---|---|
| TODO | 1804 | Where is this called from? |
| TODO | 2034 | Where is this called from? |
| TODO | 2119 | Where is this called from? |
| TODO | 2199 | Where is this called from? |
| TODO | 2294 | Use user session? |
| TODO | 2294 | Used? |
| TODO | 1920 | What's the Difference between lang and langdata? |
| TODO | 2530 | This is a comma separated string of ids |
| TODO | 2565 | This code can't be reached |
| TODO | 2634 | Maybe do this with SQL instead? |
PluginHelper.php
| Type | Line | Description |
|---|---|---|
| TODO | 6 | Better name? |
PluginManagerController.php
| Type | Line | Description |
|---|---|---|
| TODO | 23 | Apply new permission 'extensions' instead of 'settings'. |
| TODO | 206 | Defensive programming |
| TODO | 665 | Might have different file fetcher. |
| TODO | 681 | Duplicate from themes.php. |
| TODO | 711 | Duplicate from themes.php. |
| TODO | 320 | Break out to separate method. |
PrintableSurvey.php
| Type | Line | Description |
|---|---|---|
| TODO | 328 | Fallthru on purpose? |
Saved.php
| Type | Line | Description |
|---|---|---|
| TODO | 70 | write function |
SurveysGroupsController.php
| Type | Line | Description |
|---|---|---|
| TODO | 264 | : find where it shown |
| TODO | 264 | : fix $_POST call |
Themes.php
| Type | Line | Description |
|---|---|---|
| TODO | 537 | Used? Previous name: _strip_ext |
| TODO | 1424 | Move to service class |
| TODO | 1424 | Same logic for survey theme |
| TODO | 1451 | Remove this? Doesn't seem to be used anymore. |
| TODO | 298 | Don't branch on $_POST, but on config.xml <type> tag. |
| TODO | 308 | Replace with extension installer factory. |
| TODO | 329 | If you want to do nice file upload summary, you need to define a |
| TODO | 378 | Always check if successful. |
| TODO | 385 | Move all this to new SurveyThemeInstaller class (same as done for QuestionThemeInstaller). |
| TODO | 423 | Always check if successful. |
| TODO | 427 | make proper import manifest for questiontheme in configuration class |
| TODO | 437 | Always check if successful. |
| TODO | 562 | check if we can load template without needing the model, only from xml, so we can load the theme editor even when it is not installed |
| TODO | 1150 | check if this aData is still used |
| TODO | 1162 | try if it can be removed |
Tokens.php
| Type | Line | Description |
|---|---|---|
| TODO | 368 | separate this function in two: one for single delete and one for multiple delete |
| TODO | 40 | : check if it does something different than the model function |
| TODO | 660 | This part could be refactored into function like "insertToken()" |
| TODO | 1583 | Rename 'ok' to something meaningful. |
Update.php
| Type | Line | Description |
|---|---|---|
| TODO | 593 | : if no update available, set session about it... |
AdminController.php
| Type | Line | Description |
|---|---|---|
| TODO | 247 | check if it is the case for all controllers, if not normalize it, so 3rd party coder can easily extend any LS Core controller/action/view. |
AssessmentController.php
| Type | Line | Description |
|---|---|---|
| TODO | 214 | Show error details to the user? |
| TODO | 258 | Show error details to the user? |
InstallerController.php
| Type | Line | Description |
|---|---|---|
| TODO | 750 | Not used? Compare models/InstallerConfigForm::getHasMinimumRequirements |
PluginsController.php
| Type | Line | Description |
|---|---|---|
| TODO | 7 | Not used, copied to admin/pluginmanager.php. Delete this file? |
| TODO | 7 | Actually, it's used for action direct. |
QuestionAdministrationController.php
| Type | Line | Description |
|---|---|---|
| TODO | 342 | php warning (Missing return statement) |
| TODO | 482 | is this action still in use?? where in the frontend? |
| TODO | 672 | document me |
| TODO | 738 | Permission check hard when both sid and gid are given. |
| TODO | 774 | Permission |
| TODO | 774 | Should be GET, not POST |
| TODO | 793 | Permission |
| TODO | 793 | Should be GET, not POST |
| TODO | 849 | Document. |
| TODO | 849 | Too many arguments. |
| TODO | 898 | docs |
| TODO | 1046 | document me. |
| TODO | 1046 | is this used in frontend somewherer? can't find it |
| TODO | 2366 | document me |
| TODO | 2386 | document me. |
| TODO | 2386 | move this function somewhere else, this should not be part of controller ... (e.g. model) |
| TODO | 2509 | Move to PreviewModalWidget? |
| TODO | 215 | No difference between true and false? |
| TODO | 239 | 'assessmentvisible' => false, |
| TODO | 249 | Problem with CSRF cookie when entering directly after login. |
| TODO | 576 | Double check |
| TODO | 853 | calcul correct value |
| TODO | 856 | Fix question type 'A'. Needed? |
| TODO | 1068 | Rename Variable for better readability. |
| TODO | 1285 | $questionMetaData should be $questionThemeSettings |
| TODO | 1592 | Better solution: Hard-code allowed CSS classes. |
| TODO | 1662 | Difference between create and update permissions? |
| TODO | 1842 | 'assessmentvisible' => false, |
RegisterController.php
| Type | Line | Description |
|---|---|---|
| TODO | 379 | : move xss filtering in model |
StatisticsUserController.php
| Type | Line | Description |
|---|---|---|
| TODO | 45 | Not used? |
SurveyIndex.php
| Type | Line | Description |
|---|---|---|
| TODO | 296 | can this be moved to the top? |
SurveyAdministrationController.php
| Type | Line | Description |
|---|---|---|
| TODO | 645 | is this function used? the function editlocalsetting does not exists (also not in old controller surveyadmin) |
| TODO | 953 | this could go to the questiongroupAdministrationController ? |
| TODO | 1247 | this could go into surveymenucontroller |
| TODO | 2238 | Add TypeDoc. |
| TODO | 2545 | this function should be moved to another controller (?) |
| TODO | 2651 | While refactoring (at some point) this function should be removed and only one unique identifier should be used |
| TODO | 2675 | is this new implementation??? |
| TODO | 2712 | Change function name to _showOrganizeGroupsAndQuestions? |
| TODO | 2712 | Does actually not show anything, but gets data. So getReorderFormData()? |
SurveysController.php
| Type | Line | Description |
|---|---|---|
| TODO | 86 | Remove? It seems this can never happen because it's already caught by LSYii_Application::onException() (see commit c792c2e). |
| TODO | 134 | Remove comment code. |
ThemeOptionsController.php
| Type | Line | Description |
|---|---|---|
| TODO | 762 | While refactoring (at some point) this function should be removed and only one unique identifier should be used |
UploaderController.php
| Type | Line | Description |
|---|---|---|
| TODO | 120 | Split into two controller methods. |
| TODO | 339 | : unlink this file since this is just a preview. But we can do it only if it's not needed, and still needed to have the file content |
UserGroupController.php
| Type | Line | Description |
|---|---|---|
| TODO | 154 | Is this still right on 6.0? |
| TODO | 490 | Show error message? |
UserManagementController.php
| Type | Line | Description |
|---|---|---|
| TODO | 494 | : move this to a private function !!! |
| TODO | 1584 | : move to and private function, but need review unit test before. |
| TODO | 1672 | : move to private function |
LimeMailer.php
| Type | Line | Description |
|---|---|---|
| TODO | 635 | Original AltBody is overwritten by msgHTML. Do we need to set it again if there was one? |
LS_Twig_Extension.php
| Type | Line | Description |
|---|---|---|
| TODO | 644 | in_array_r is not defined - delete this method? |
LsDefaultDataSets.php
| Type | Line | Description |
|---|---|---|
| TODO | 1542 | This tutorial is broken when subquestions and answer options are on the same page. |
LSETwigViewRenderer.php
| Type | Line | Description |
|---|---|---|
| TODO | 233 | missing return statement (php warning) |
| TODO | 399 | missing return statement (php warning) |
| TODO | 663 | move all the display logic to surveyRuntime so we don't need this function here |
| TODO | 835 | find a way to fix in beforeCloseHtml @see https://bugs.limesurvey.org/view.php?id=13889 |
| TODO | 101 | Panic or default to something else? |
| TODO | 206 | Panic or default to something else? |
| TODO | 710 | Same issue as commit 2972aea41c51c74db95bfe40c337ae839471152c |
LSUserIdentity.php
| Type | Line | Description |
|---|---|---|
| TODO | 70 | rename the plugin function authenticate() |
LSYii_Application.php
| Type | Line | Description |
|---|---|---|
| TODO | 150 | check the whole configuration process. It must be easier and clearer. Too many repetitions |
| TODO | 494 | get the tags, filters, etc |
LSYii_ClientScript.php
| Type | Line | Description |
|---|---|---|
| TODO | 297 | check if tmp directory can be named differently via config |
LSYii_ImageValidator.php
| Type | Line | Description |
|---|---|---|
| TODO | 54 | Why hard-coded? |
LSYii_Validators.php
| Type | Line | Description |
|---|---|---|
| TODO | 308 | Check for other schemes? FTP? vbscript? |
| TODO | 319 | Recurse? |
Authdb.php
| Type | Line | Description |
|---|---|---|
| TODO | 188 | Should we show the actual error? Taking a conservative approach of not revealing the actual cause for now. |
TFAUserKey.php
| Type | Line | Description |
|---|---|---|
| TODO | 90 | should be static |
LoadQuestionTypes.php
| Type | Line | Description |
|---|---|---|
| TODO | 8 | Configure autoloader in composer.json instead of this |
RenderMultipleChoice.php
| Type | Line | Description |
|---|---|---|
| TODO | 135 | : check if $sValueHidden === $sValue |
RenderMultipleChoiceWithComments.php
| Type | Line | Description |
|---|---|---|
| TODO | 134 | : check if it should be the same than javavalue |
| TODO | 194 | : check if it should be the same than javavalue |
SurveyCommonAction.php
| Type | Line | Description |
|---|---|---|
| TODO | 636 | Make quick-menu user configurable |
| TODO | 268 | : while refactoring, we must replace the use of $aViewUrls by $aData[.. conditions ..], |
| TODO | 297 | : http://goo.gl/ABl5t5 |
| TODO | 382 | Real fix: No database queries while doing database update, meaning |
WrongTemplateVersionException.php
| Type | Line | Description |
|---|---|---|
| TODO | 9 | Put in another folder? |
FormElement.php
| Type | Line | Description |
|---|---|---|
| TODO | 9 | Is this class needed, or can it be included in widget DVOs? |
| TODO | 9 | $name is always null, always === $id. |
PreviewModalWidget.php
| Type | Line | Description |
|---|---|---|
| TODO | 7 | Split into two widgets? |
AdvancedSettingWidget.php
| Type | Line | Description |
|---|---|---|
| TODO | 23 | Classes instead of array. |
GeneralOptionWidget.php
| Type | Line | Description |
|---|---|---|
| TODO | 18 | Classes instead of switch. |
GroupSelectorGeneralOption.php
| Type | Line | Description |
|---|---|---|
| TODO | 45 | array_map? |
SettingsWidget.php
| Type | Line | Description |
|---|---|---|
| TODO | 326 | $name is not used |
| TODO | 408 | $form is not used. |
| TODO | 466 | $name is not used |
| TODO | 466 | $form is not used |
| TODO | 569 | $name is not used |
| TODO | 517 | Where is this class added in the first place?? |
| TODO | 580 | $itemMetaData['htmlOtions']['id']=$itemName.$key or something like this |
UserPermissionsWidget.php
| Type | Line | Description |
|---|---|---|
| TODO | 11 | Classes instead of switch. |
ajax_helper.php
| Type | Line | Description |
|---|---|---|
| TODO | 161 | Check if user is logged in |
import_helper.php
| Type | Line | Description |
|---|---|---|
| TODO | 2146 | Use transactions to prevent orphaned data and clean rollback on errors |
| TODO | 133 | Should this depend on $bTranslateLinksFields? |
| TODO | 421 | Should this depend on $bTranslateLinksFields? |
| TODO | 747 | Should this depend on $options['translinkfields']? |
| TODO | 981 | Should this depend on $options['translinkfields']? |
| TODO | 2541 | Should this depend on $bTranslateLinksFields? |
label_helper.php
| Type | Line | Description |
|---|---|---|
| FIXME | 74 | undefined function |
| TODO | 179 | Show an actual error message |
common_helper.php
| Type | Line | Description |
|---|---|---|
| TODO | 852 | Move to defaulttexts helper |
| TODO | 3200 | This should probably never be used, since it returns 0 from CLI and makes PHPUnit think all is fine :( |
| FIXME | 597 | rename and/or document this |
| TODO | 1956 | SQrelevance for different scales? $fieldmap[$fieldname]['SQrelevance']=$abrow['relevance']; |
| TODO | 2579 | input Survey Object |
| TODO | 2599 | input Survey Object |
| TODO | 3414 | : Adding the onload/onhover etc ... or remove this false security function |
| TODO | 4868 | remove one of the Yii::app()->session see bug #5901 |
| TODO | 5069 | RFC7239 full implementation (https://datatracker.ietf.org/doc/html/rfc7239#section-5.2) |
export_helper.php
| Type | Line | Description |
|---|---|---|
| TODO | 2670 | refactor and simplify this code |
em_core_helper.php
| Type | Line | Description |
|---|---|---|
| TODO | 2641 | Unify errors and warnings with a EMErrorComparableInterface |
| TODO | 100 | - change this back to false |
| TODO | 565 | try to determine datatype? |
| TODO | 1972 | - Since want to use <span> for dynamic substitution, what if there are recursive substititons? |
em_manager_helper.php
| Type | Line | Description |
|---|---|---|
| TODO | 7096 | : add directly hidden input in page without return it. |
| TODO | 9929 | : validate if it work : unsure it was shown always to user (nojs ?) |
| TODO | 30 | Fix autoloading of warnings. |
| TODO | 270 | - add example from survey using assessments |
| TODO | 360 | ?? Equation result for validation |
| TODO | 410 | - ?? |
| TODO | 414 | ?? |
| TODO | 1300 | - implement qcode naming for this |
| TODO | 1499 | generic validation as to dateformat[SGQA].value : BUT not same in PHP and JS |
| TODO | 2630 | - create equations for these? |
| TODO | 2633 | ? How does it work? |
| TODO | 3038 | - create em_num_files class so can sepately style num_files vs. num_answers |
| TODO | 3283 | - do I need to force refresh, or trust that createFieldMap will cache languages properly? |
| TODO | 3634 | Internal error if this happens |
| TODO | 4165 | - in a running survey, only need to process the current Group. For Admin mode, do we need to process all prior questions or not? |
| TODO | 4300 | - cache results and generated JavaScript equations? |
| TODO | 4647 | default should eventually be false |
| TODO | 4852 | only important thing from StartProcessingGroup? |
| TODO | 5099 | only important thing from StartProcessingGroup? |
| TODO | 5157 | - now that using $this->updatedValues, may be able to remove local copies of it (unless needed by other sub-systems) |
| TODO | 5244 | Internal error if this happens |
| TODO | 5647 | only important thing from StartProcessingGroup? |
| TODO | 5799 | - what is desired behavior? |
| TODO | 5941 | how used if random? |
| TODO | 5996 | is this needed? |
| TODO | 6106 | is this needed? |
| TODO | 6142 | is this needed? |
| TODO | 6186 | is this needed? |
| TODO | 6221 | is this needed? |
| TODO | 6251 | - check this |
| TODO | 6256 | - why is array_unique needed here? |
| TODO | 6353 | - what about 'other'? |
| TODO | 6397 | - what about 'other'? |
| TODO | 6422 | - what about 'other'? |
| TODO | 6636 | check for errors? |
| TODO | 6641 | - currently invalidates all - should only invalidate those that truly fail validation rules. |
| TODO | 7006 | - what if this is called using Survey or Data Entry format? |
| TODO | 7511 | Internal error if this happens |
| TODO | 7870 | - is different type needed for text? Or process value to striphtml? |
| TODO | 8684 | Make a wrapper class around date converter, which constructor takes to-lang and from-lang |
| TODO | 8940 | jsName_on will never be returned? |
em_cache_helper.php
| Type | Line | Description |
|---|---|---|
| TODO | 118 | Setting per survey. |
| TODO | 118 | Don't cache questions with expressions. |
EMWarningHTMLBaker.php
| Type | Line | Description |
|---|---|---|
| TODO | 55 | Factor out in warning classes OOP |
frontend_helper.php
| Type | Line | Description |
|---|---|---|
| TODO | 1454 | Rename |
| TODO | 1454 | Move HTML to view |
| TODO | 1939 | Deprecated - Question timers no longer use cookies |
| TODO | 18 | Why needed? |
| TODO | 1052 | rewrite this THE YII WAY !!!! (application/vendor + internal config for namespace + aliases; etc) |
Hash.php
| Type | Line | Description |
|---|---|---|
| FIXME | 105 | !!! |
LayoutHelper.php
| Type | Line | Description |
|---|---|---|
| TODO | 491 | Make quick-menu user configurable |
| TODO | 433 | : create subfunctions |
qanda_helper.php
| Type | Line | Description |
|---|---|---|
| TODO | 382 | : check if really deprecated (date : 20240902) |
| TODO | 114 | This can be cached in some special cases. |
| TODO | 640 | Regression here? Should use LEMval(minfiles) like above |
| TODO | 2564 | What is this? What is happening here? |
questionHelper.php
| Type | Line | Description |
|---|---|---|
| TODO | 1242 | add these later? "1F", |
| TODO | 1252 | add these later? "1F", |
remotecontrol_handle.php
| Type | Line | Description |
|---|---|---|
| TODO | 3375 | Need to clean up return array, especially the case when response was added but file not uploaded. |
| TODO | 3375 | See discussion: https://bugs.limesurvey.org/view.php?id=13794 |
sanitize_helper.php
| Type | Line | Description |
|---|---|---|
| TODO | 311 | define the exact format of the username |
| TODO | 324 | define the exact format of the username |
SurveyRuntimeHelper.php
| Type | Line | Description |
|---|---|---|
| TODO | 1405 | : find/get current qid for processing string |
| TODO | 1483 | : move to coreReplacements ? Can be good. |
| TODO | 169 | To respect object oriented design, all those "states" should be move to Response model, or its related models via relations. |
| TODO | 235 | move somewhere else |
| TODO | 301 | - retrieveAnswers is slow - queries database separately for each question. May be fixed in _CI or _YII ports, so ignore for now |
| TODO | 770 | set this to true if in admin mode but not if running a survey |
| TODO | 892 | twig |
| TODO | 1235 | check that line: |
| TODO | 1586 | find where they are defined before this call |
| TODO | 1655 | check with markus why $loadall, it's never ever defined, even in master branch |
| TODO | 1772 | check this: |
surveytranslator_helper.php
| Type | Line | Description |
|---|---|---|
| TODO | 1315 | Should not give back different data types |
updatedb_helper.php
| Type | Line | Description |
|---|---|---|
| TODO | 3381 | Move to class? |
| TODO | 1095 | Inject user model instead. Polling for user will create a session, which breaks on command-line. |
| TODO | 1630 | Don't use models in updatedb_helper. |
Update_700.php
| Type | Line | Description |
|---|---|---|
| TODO | 450 | SQrelevance for different scales? $fieldmap[$fieldname]['SQrelevance']=$abrow['relevance']; |
userstatistics_helper.php
| Type | Line | Description |
|---|---|---|
| TODO | 1844 | Support three or more duplicates. |
viewHelper.php
| Type | Line | Description |
|---|---|---|
| TODO | 254 | : filter inline javascript (onclick etc ..., but don't filter EM javascript) Maybe doing it directly in LEM->GetLastPrettyPrintExpression(); |
BigData.php
| Type | Line | Description |
|---|---|---|
| TODO | 229 | No other types supported, ever? |
ExtensionUpdater.php
| Type | Line | Description |
|---|---|---|
| TODO | 193 | Move to parent class? |
| TODO | 32 | Create interface ExtensionModelInterface that all extension model classes implement |
FileFetcherUploadZip.php
| Type | Line | Description |
|---|---|---|
| TODO | 189 | Duplicate from themes.php. |
| TODO | 259 | Inject FileIO wrapper and add unit-test |
| TODO | 285 | When should this return false? |
PluginInstaller.php
| Type | Line | Description |
|---|---|---|
| TODO | 91 |
QuestionThemeInstaller.php
| Type | Line | Description |
|---|---|---|
| TODO | 18 | Move to parent class? |
| TODO | 122 | |
| TODO | 154 | Should this be stricter, e.g. only allow alphanumeric characters plus hyphens and underscores? |
ThemeUpdater.php
| Type | Line | Description |
|---|---|---|
| TODO | 22 | Survey theme, question theme, admin theme...? |
VersionFetcherServiceLocator.php
| Type | Line | Description |
|---|---|---|
| TODO | 49 | Not implemented. |
OpHandlerActiveRecordUpdate.php
| Type | Line | Description |
|---|---|---|
| TODO | 78 | Implement validateOperation() method. |
PluginManager.php
| Type | Line | Description |
|---|---|---|
| TODO | 271 | Factor out |
| TODO | 351 | Read config.xml instead. |
| TODO | 605 | Localization. |
| TODO | 632 | Localization. |
SmtpOAuthPluginBase.php
| Type | Line | Description |
|---|---|---|
| TODO | 111 | Handle token with invalid scope (ie. missing https://mail.google.com/) |
| TODO | 130 | Should we use a different exception class? |
Save.php
| Type | Line | Description |
|---|---|---|
| TODO | 173 | $this->aSaveErrors |
| TODO | 200 | $this->aSaveErrors |
AdminTheme.php
| Type | Line | Description |
|---|---|---|
| TODO | 101 | replace everywhere the call to Yii::app()->getConfig('adminstyleurl) by $oAdminTheme->sTemplateUrl; |
Answer.php
| Type | Line | Description |
|---|---|---|
| TODO | 115 | get via Question relations |
Condition.php
| Type | Line | Description |
|---|---|---|
| TODO | 74 | should be singular, not plural |
ExtensionConfig.php
| Type | Line | Description |
|---|---|---|
| TODO | 38 | Get detailed error message. |
LabelSet.php
| Type | Line | Description |
|---|---|---|
| TODO | 280 | create a Validator to be used for all such element : no need HTML, informative input used only for admin purpose. |
LSActiveRecord.php
| Type | Line | Description |
|---|---|---|
| TODO | 195 | This should also be moved to the behavior at some point. This method overrides the parent in order to raise PluginEvents for Bulk delete operations. Filter Criteria are wrapped into a CDBCriteria instance so we have a single instance responsible for holding the filter criteria to be passed to the PluginEvent, this also enables us to pass the fully configured CDBCriteria instead of the original Parameters. See {@link find()} for detailed explanation about $condition and $params. |
| TODO | 469 | Use OOP polymorphism instead of switching on class names. |
Notification.php
| Type | Line | Description |
|---|---|---|
| TODO | 272 | : via survey relations |
| TODO | 285 | this should be in Survey model (relations?) |
| TODO | 301 | this should be in Survey model |
| TODO | 317 | Check first_read = null instead? |
| TODO | 361 | read = null? |
Participant.php
| Type | Line | Description |
|---|---|---|
| TODO | 1910 | Weird... |
| TODO | 1952 | What is id here? Could it overwrite something? |
ParticipantAttributeName.php
| Type | Line | Description |
|---|---|---|
| TODO | 765 | Doc |
ParticipantShare.php
| Type | Line | Description |
|---|---|---|
| TODO | 29 | should be singular |
Permission.php
| Type | Line | Description |
|---|---|---|
| TODO | 772 | move to private function |
| TODO | 843 | Use data value object instead of array. |
| TODO | 515 | in entry script, if CConsoleApplication, set user as superadmin |
| TODO | 522 | plugin should not be able to override the permission system (security issue), |
| TODO | 540 | see above about entry script and superadmin |
| TODO | 546 | should not be necessary |
Permissiontemplates.php
| Type | Line | Description |
|---|---|---|
| TODO | 254 | should be static |
Plugin.php
| Type | Line | Description |
|---|---|---|
| TODO | 79 | Works on all SQL systems? |
Question.php
| Type | Line | Description |
|---|---|---|
| TODO | 1026 | : move other fix here ? |
| TODO | 584 | move to QuestionType |
| TODO | 1459 | Assuming no collision. |
QuestionAttribute.php
| Type | Line | Description |
|---|---|---|
| TODO | 34 | Should probably change question_attributes table to question_attribute_values |
| TODO | 66 | Remove? |
| TODO | 104 | A function should not both set and get something; split into two functions |
| TODO | 136 | A function should not both set and get something; split into two functions |
| TODO | 380 | Move to static property? |
| TODO | 518 | What's the opposite of a "general" attribute? How many types of attributes are there? |
QuestionCreate.php
| Type | Line | Description |
|---|---|---|
| TODO | 11 | This is a factory method, not a singleton. Rename to make() or create(). |
| TODO | 78 | check why return both empty array and null? |
QuestionL10n.php
| Type | Line | Description |
|---|---|---|
| FIXME | 60 | this conflicts with the attribute "question" |
QuestionTemplate.php
| Type | Line | Description |
|---|---|---|
| TODO | 399 | Move to QuestionTheme? |
| TODO | 399 | This is not the same as QuestionTheme::findQuestionMetaDataForAllTypes() which is the database layer |
| TODO | 399 | this should check the filestructure instead of the database as this is the filestructure layer |
QuestionTheme.php
| Type | Line | Description |
|---|---|---|
| TODO | 259 | Please never redirect at this level, only from controllers. |
| TODO | 341 | Move to service class |
| TODO | 374 | Replace assoc array with DTO |
| TODO | 506 | move actions to its controller and split between controller and model, related search for: 1573123789741 |
| TODO | 506 | Move to QuestionThemeInstaller |
| TODO | 730 | Naming is wrong, it does not "get", it "convertTo" |
| TODO | 730 | Possibly make a DTO for question metadata instead, and implement the ArrayAccess interface or "toArray()" |
| TODO | 318 | replace by manifest |
| TODO | 520 | Now that core question themes can't be deleted, the following check |
| TODO | 670 | should be moved into DB column (question_theme_settings table) |
| TODO | 813 | Make it always relative depending on question theme type (core, custom, user). |
| TODO | 817 | Check json_last_error. |
QuestionType.php
| Type | Line | Description |
|---|---|---|
| TODO | 61 | make it boolean instead */ |
Response.php
| Type | Line | Description |
|---|---|---|
| TODO | 219 | Internal error - wrong filename saved? |
SavedControl.php
| Type | Line | Description |
|---|---|---|
| TODO | 116 | this is a unfinished functionality resendAccesscode |
CreateSurvey.php
| Type | Line | Description |
|---|---|---|
| TODO | 78 | Localization? |
ParticipantBlacklistHandler.php
| Type | Line | Description |
|---|---|---|
| TODO | 62 | Remove 'OptOut' status from all surveys if 'blacklistallsurveys' setting is true? |
| TODO | 79 | Should we also try to match by email? |
PasswordManagement.php
| Type | Line | Description |
|---|---|---|
| TODO | 205 | it's fine to use static functions, until it is used only in controllers ... |
PermissionManager.php
| Type | Line | Description |
|---|---|---|
| TODO | 117 | : Save Permission by POST value according to current user permission |
| TODO | 270 | Static methods cannot be mocked. |
L10nService.php
| Type | Line | Description |
|---|---|---|
| TODO | 44 | document me |
QuestionAttributeHelper.php
| Type | Line | Description |
|---|---|---|
| TODO | 55 | Pure function - move outside class? |
| TODO | 101 | Pure function - move outside class? |
| TODO | 143 | Pure function - move outside class? |
| TODO | 234 | No state used, so no OOP needed, move to function at some point. |
QuickTranslation.php
| Type | Line | Description |
|---|---|---|
| TODO | 20 | All the swithc-statements could be remade using OOP instead. |
Quotas.php
| Type | Line | Description |
|---|---|---|
| TODO | 17 | Possible remove this warning |
| TODO | 102 | Refactor and remove phpmd warning |
GeneralSettings.php
| Type | Line | Description |
|---|---|---|
| TODO | 583 | Should really be saved as three fields in the database! |
| TODO | 583 | Copied from Survey:::saveTranscribeCaptchaOptions() replace uses of original copy |
SurveyCondition.php
| Type | Line | Description |
|---|---|---|
| TODO | 1729 | Move to service class |
SurveysGroupCreator.php
| Type | Line | Description |
|---|---|---|
| TODO | 57 | What happen if SurveysGroups saved but no SurveysGroupsettings? Transaction? |
SurveyThemeConfiguration.php
| Type | Line | Description |
|---|---|---|
| TODO | 290 | incorporate this option type into the theme properly |
| TODO | 295 | AT-1896 - force temporary theme color to be of icon type for the API |
SurveyUseCaptcha.php
| Type | Line | Description |
|---|---|---|
| TODO | 65 | Is this used? To be deprecated? |
UserManager.php
| Type | Line | Description |
|---|---|---|
| TODO | 120 | User permissions should be deleted also... |
Survey.php
| Type | Line | Description |
|---|---|---|
| TODO | 950 | this function can go directly into Surveymenu, why implemented it here? ($this is used here ...) This will be made bigger in future releases, but right now it only collects the default menu-entries |
| TODO | 1908 | : move to PermissionInterface |
| TODO | 1908 | : create an event |
| TODO | 1986 | Should really be saved as three fields in the database! |
| TODO | 2368 | use it in surveyspermission |
SurveyActivator.php
| Type | Line | Description |
|---|---|---|
| TODO | 7 | Move to models/services/survey/ folder. |
| FIXME | 409 | @ not good |
| FIXME | 413 | @ not good |
SurveyDeactivator.php
| Type | Line | Description |
|---|---|---|
| TODO | 8 | Move to models/services/survey/ folder. |
SurveyDynamic.php
| Type | Line | Description |
|---|---|---|
| TODO | 714 | This provide a first step to enable the old jQgrid selector system, and could be use for users and tokens |
SurveyLanguageSetting.php
| Type | Line | Description |
|---|---|---|
| TODO | 285 | : rename and fix this |
SurveyLink.php
| Type | Line | Description |
|---|---|---|
| TODO | 155 | this should be in survey model |
SurveyTimingDynamic.php
| Type | Line | Description |
|---|---|---|
| TODO | 168 | $language is not used locally |
Template.php
| Type | Line | Description |
|---|---|---|
| TODO | 293 | we can not trust the filestate and need to be |
| TODO | 567 | this probably not use any more. Check and remove it. |
TemplateConfig.php
| Type | Line | Description |
|---|---|---|
| TODO | 278 | document me |
| TODO | 849 | document me |
TemplateConfiguration.php
| Type | Line | Description |
|---|---|---|
| TODO | 106 | document me |
| TODO | 115 | document me |
| TODO | 139 | document me |
| TODO | 151 | document me |
| TODO | 661 | document me |
| TODO | 912 | document me |
| TODO | 1268 | document me |
| TODO | 1422 | document me |
| TODO | 1542 | document me |
| TODO | 225 | Move to SurveyGroup creation, right now the 'lazy loading' approach is ok. |
TemplateManifest.php
| Type | Line | Description |
|---|---|---|
| TODO | 646 | load to DB |
| TODO | 657 | Installs Theme (maybe rename importManifest to install ?) |
| TODO | 1082 | create a method "setToDefault" |
Token.php
| Type | Line | Description |
|---|---|---|
| TODO | 53 | Describe me! |
TokenDynamic.php
| Type | Line | Description |
|---|---|---|
| TODO | 35 | Describe me! |
UpdateForm.php
| Type | Line | Description |
|---|---|---|
| TODO | 247 | $downloadid not used locally |
| TODO | 318 | Deal with error here |
| TODO | 509 | : add postgresql |
| TODO | 1073 | : Could test if curl is loaded, and if not, use httprequest2 |
UserGroup.php
| Type | Line | Description |
|---|---|---|
| TODO | 127 | should use save() and afterSave() methods!! |
| TODO | 281 | where is this used?? |
| TODO | 85 | seems to be unused, probably shouldn't be done like that |
UserInGroup.php
| Type | Line | Description |
|---|---|---|
| TODO | 61 | should be singular |
create-database.php
| Type | Line | Description |
|---|---|---|
| TODO | 893 | varchar(200) is too big for MySQL index, the index will be truncated to 191 chars. |